对于spring boot应用程序,我有以下代码:
实体:
@Proxy(lazy = false)
public class Vehicle {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
private String type;
private String make;
private String model;
private Integer year;
控制器:
@RequestMapping("/vehicles")
public class VehicleController {
@Autowired
private VehicleService vehicleService;
//GET method to get all vehicles, or specify a parameter
@GetMapping
@ResponseStatus(HttpStatus.OK)
public List<Vehicle> getAllVehicles(
@RequestParam(required = false) Map<String, String> allParams) {
return vehicleService.getVehicles(allParams);
}
服务:
private VehicleRepository vehicleRepository;
/**
* Gets the full list of vehicles based on the provided parameters. If no parameters are
* presented, then returns the entire list of vehicles
*
* @param allParams A map of all possible parameters that can be passed through
* @return list of vehicles
*/
@Override
public List<Vehicle> getVehicles(Map<String, String> allParams) {
//gather all of the possible parameters that can be passed through
String type = allParams.get("type");
String make = allParams.get("make");
String model = allParams.get("model");
Integer year;
try {
year = Integer.parseInt(allParams.get("year"));
} catch (NumberFormatException n) {
year = 0;
}
if (type != null && make != null && model != null && year != 0) {
return vehicleRepository.findByTypeAndMakeAndModelAndYear(type, make, model, year);
}
if (make != null && type == null && model != null && year != 0) {
return vehicleRepository.findByMakeAndModelAndYear(make, model, year);
}
if (type != null && make == null && model != null && year != 0) {
return vehicleRepository.findByTypeAndModelAndYear(type, model, year);
}
if (type != null && make != null && model == null && year != 0) {
return vehicleRepository.findByTypeAndMakeAndYear(type, make, year);
}
if (model != null && type == null && make == null && year != 0) {
return vehicleRepository.findByModelAndYear(model, year);
}
if (make != null && type == null && model == null && year != 0) {
return vehicleRepository.findByMakeAndYear(make, year);
}
if (type != null && make == null && model == null && year != 0) {
return vehicleRepository.findByTypeAndYear(type, year);
}
if (type != null && make != null && model != null) {
return vehicleRepository.findByTypeAndMakeAndModel(type, make, model);
}
if (make != null && type == null && model != null) {
return vehicleRepository.findByMakeAndModel(make, model);
}
if (type != null && make == null && model != null) {
return vehicleRepository.findByTypeAndModel(type, model);
}
if (type != null && make != null) {
return vehicleRepository.findByTypeAndMake(type, make);
}
if (type != null) {
return vehicleRepository.findByType(type);
}
if (make != null) {
return vehicleRepository.findByMake(make);
}
if (model != null) {
return vehicleRepository.findByModel(model);
}
if (year != 0) {
return vehicleRepository.findByYear(year);
}
return vehicleRepository.findAll();
}
存储库:
public interface VehicleRepository extends JpaRepository<Vehicle, Long> {
List<Vehicle> findByTypeAndMakeAndModelAndYear(String type, String make, String model,
Integer year);
List<Vehicle> findByMakeAndModelAndYear(String make, String model, Integer year);
List<Vehicle> findByTypeAndModelAndYear(String type, String model, Integer year);
List<Vehicle> findByTypeAndMakeAndYear(String type, String make, Integer year);
List<Vehicle> findByModelAndYear(String model, Integer year);
List<Vehicle> findByMakeAndYear(String make, Integer year);
List<Vehicle> findByTypeAndYear(String type, Integer year);
List<Vehicle> findByTypeAndMakeAndModel(String type, String make, String model);
List<Vehicle> findByMakeAndModel(String make, String model);
List<Vehicle> findByTypeAndModel(String type, String model);
List<Vehicle> findByTypeAndMake(String type, String make);
List<Vehicle> findByType(String type);
List<Vehicle> findByMake(String make);
List<Vehicle> findByModel(String model);
List<Vehicle> findByYear(Integer year);
}
显然,服务层有很多条件逻辑来覆盖所传递参数的多个组合。它实现了我的目标,即对通过的任何查询进行说明(即。 http://localhost:8080/vehicles?make=&model=&year=&type=
),我想知道是否有办法重构代码以提高效率。spring的示例查询是否足以解决这个问题,或者有更好的方法吗(或者这是我能做的最好的代码?)
1条答案
按热度按时间d8tt03nd1#
我建议
Spring JPA ExampleMatcher
. 它是最简单的jpa查询方法之一。你创造了一个probe
定义在数据库上搜索的变量。查询中只包含非空值,有关详细信息,请参阅spring data jpa query by example。而且,我用过Lombok
图书馆@Data
注解。如果你不喜欢,可以把它扔掉。车辆.java
车辆控制器.java
车辆存储.java
车辆服务.java