ant-design All checkboxes are re-rendered in each render in a table with rowSelection enabled

pzfprimi 于 2022-10-25 发布在其他

关注(0)|答案(5)|浏览(167)

I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Steps to reproduce

open the codesandbox demo in a new window
open the react dev tools profiler tab, checkRecord why each component rendered while profiling.
start the react dev tools profiling
check one record in the demo table
stop the react dev tools profiling
in the flamegraph, one can see every single checkbox is re-rendered with reasons saying:"Props changed: (onClick, onChange)"

What is expected?

Only the relative checkbox should be re-rendered.

What is actually happening?

All checkboxes are re-rendered.

Environment	Info
antd	4.12.3
React	17.0.1
System	Windows 10 Pro 20H2 19042.804
Browser	Microsoft Edge 88.0.705.74

There will be a noticeable UI lagging when there are hundreds of records in a table. onClick and onChange shouldn't be updated in each render.

ant-design

来源：https://github.com/ant-design/ant-design/issues/29543

5条答案

按热度按时间

0mkxixxg1#

Selection column should implement shouldCellUpdate internally.

赞(0）回复(0）举报 2022-10-25

vc9ivgsu2#

Hello @Sec-ant. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Sec-ant，我们完全同意你的提议/反馈，欢迎直接在此仓库创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。