您有一些语法错误，需要将字符串作为函数参数传递。
从我可以告诉你想要首先选择一个字符，然后改变输出的基础上，您的选择。
您的代码几乎可以正常工作了，您只需要修复语法错误并将选择保存在一个变量中，以便能够将其传递给下一个函数。

def selectcharacter():
    character = ""
    while character != "Red pirate" and character != "Dreed prince":  
        character = input("which character you want to choose? (Red pirate or Dreed prince ):")

    return character

def checkcharacter(chosencharacter):
    if (chosencharacter == "Red pirate"):  # should be string
        print("the ability of the character is to fight close range battles and has 125 health and 50 armor!"),
    elif (chosencharacter == "Dreed prince"):  # should be string
        print("the ability of the character is to fight long range battles and has 100 health and 25 armor!")
    else:
        print("no character selected.please select the character!")

selected_character = selectcharacter()
checkcharacter(selected_character)

这些字符应该被转换成字符串，这样你就可以检查它们是否等于传递的参数chosencharacter。你还应该使用elif而不是第二个if，因为，否则第二个if将被求值（为False），即使第一个是True。