I would like to point out that identifiers like "_NGINX_H_INCLUDED_" and "_NGX_HTTP_H_INCLUDED_" do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?
Thanks for your notice. It's reasonable. You can also point this problem to Nginx Development Team. This code is inherited from Nginx.
On 2012/11/26 3:44, Markus Elfring wrote: I would like to point out that identifiers like "|NGINX_H_INCLUDED| https://github.com/taobao/tengine/blob/e2708ba92ddda20bfc4499dc0d1e60c582a51c00/src/core/nginx.h#L8" and "|NGX_HTTP_H_INCLUDED| https://github.com/taobao/tengine/blob/246f4133f6a1048dce36d3e55a5c748228288da1/src/http/ngx_http.h#L8" do not fit https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-CDonotdeclareordefineareservedidentifier-NoncompliantCodeExampleHeaderGuard to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?
1条答案
按热度按时间dgiusagp1#
Thanks for your notice. It's reasonable. You can also point this problem
to Nginx Development Team. This code is inherited from Nginx.
On 2012/11/26 3:44, Markus Elfring wrote:
I would like to point out that identifiers like "|NGINX_H_INCLUDED|
https://github.com/taobao/tengine/blob/e2708ba92ddda20bfc4499dc0d1e60c582a51c00/src/core/nginx.h#L8"
and "|NGX_HTTP_H_INCLUDED|
https://github.com/taobao/tengine/blob/246f4133f6a1048dce36d3e55a5c748228288da1/src/http/ngx_http.h#L8"
do not fit
https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-CDonotdeclareordefineareservedidentifier-NoncompliantCodeExampleHeaderGuard
to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
Thanks
-YWB