What problem does this feature solve?
When making all Avatar Square in Avatar.Group
, the overflow component renders as a circle
and cannot be changed to a square
as needed by providing the shape
property to the Group.
In the screenshot below we can see that the ant-avatar ant-avatar-circle
classnames are being applied to the overflow component.
The end user experience would be to maintain the consistency of the shape of Avatars across the .Group component
What does the proposed API look like?
Provide a property to specify the shape
of the overflow to Avatar.Group
. The shape
property of Avatar.Group
would accept circle | square
5条答案
按热度按时间zwghvu4y1#
Hello @RiteshMakan. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!
你好 @RiteshMakan,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的 预设模板 ,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。
41zrol4v2#
Thank you, I will take on this task and submit a PR linking to this issue
jexiocij3#
@tianyuan233 I only saw that you also have a PR. Perhaps we can combine our efforts between your PR and
#36731
9rnv2umw4#
I have updated PR here
#36849
bhmjp9jg5#
Did I miss anything in my PR?
I see this did not get merged into 4.23.0