android AsyncTask的正确实现方式是静态还是非静态嵌套类?

n6lpvg4x  于 2023-03-27  发布在  Android
关注(0)|答案(4)|浏览(119)

Android示例中的“Login”将AsyncTask实现为非静态内部类。然而,根据Commonsguys的说法,该类应该是静态的,并使用外部活动see this的弱引用。
那么实现AsyncTask的正确方法是什么呢?静态还是非静态?

Commonsguy实现

https://github.com/commonsguy/cw-android/tree/master/Rotation/RotationAsync/

Google登录示例

package com.example.asynctaskdemo;

import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.annotation.TargetApi;
import android.app.Activity;
import android.os.AsyncTask;
import android.os.Build;
import android.os.Bundle;
import android.text.TextUtils;
import android.view.KeyEvent;
import android.view.Menu;
import android.view.View;
import android.view.inputmethod.EditorInfo;
import android.widget.EditText;
import android.widget.TextView;

/**
 * Activity which displays a login screen to the user, offering registration as
 * well.
 */
public class LoginActivity extends Activity {
    /**
     * A dummy authentication store containing known user names and passwords.
     * TODO: remove after connecting to a real authentication system.
     */
    private static final String[] DUMMY_CREDENTIALS = new String[] { "foo@example.com:hello", "bar@example.com:world" };

    /**
     * The default email to populate the email field with.
     */
    public static final String EXTRA_EMAIL = "com.example.android.authenticatordemo.extra.EMAIL";

    /**
     * Keep track of the login task to ensure we can cancel it if requested.
     */
    private UserLoginTask mAuthTask = null;

    // Values for email and password at the time of the login attempt.
    private String mEmail;
    private String mPassword;

    // UI references.
    private EditText mEmailView;
    private EditText mPasswordView;
    private View mLoginFormView;
    private View mLoginStatusView;
    private TextView mLoginStatusMessageView;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_login);

        // Set up the login form.
        mEmail = getIntent().getStringExtra(EXTRA_EMAIL);
        mEmailView = (EditText) findViewById(R.id.email);
        mEmailView.setText(mEmail);

        mPasswordView = (EditText) findViewById(R.id.password);
        mPasswordView.setOnEditorActionListener(new TextView.OnEditorActionListener() {
            @Override
            public boolean onEditorAction(TextView textView, int id, KeyEvent keyEvent) {
                if (id == R.id.login || id == EditorInfo.IME_NULL) {
                    attemptLogin();
                    return true;
                }
                return false;
            }
        });

        mLoginFormView = findViewById(R.id.login_form);
        mLoginStatusView = findViewById(R.id.login_status);
        mLoginStatusMessageView = (TextView) findViewById(R.id.login_status_message);

        findViewById(R.id.sign_in_button).setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                attemptLogin();
            }
        });
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        super.onCreateOptionsMenu(menu);
        getMenuInflater().inflate(R.menu.activity_login, menu);
        return true;
    }

    /**
     * Attempts to sign in or register the account specified by the login form.
     * If there are form errors (invalid email, missing fields, etc.), the
     * errors are presented and no actual login attempt is made.
     */
    public void attemptLogin() {
        if (mAuthTask != null) {
            return;
        }

        // Reset errors.
        mEmailView.setError(null);
        mPasswordView.setError(null);

        // Store values at the time of the login attempt.
        mEmail = mEmailView.getText().toString();
        mPassword = mPasswordView.getText().toString();

        boolean cancel = false;
        View focusView = null;

        // Check for a valid password.
        if (TextUtils.isEmpty(mPassword)) {
            mPasswordView.setError(getString(R.string.error_field_required));
            focusView = mPasswordView;
            cancel = true;
        }
        else if (mPassword.length() < 4) {
            mPasswordView.setError(getString(R.string.error_invalid_password));
            focusView = mPasswordView;
            cancel = true;
        }

        // Check for a valid email address.
        if (TextUtils.isEmpty(mEmail)) {
            mEmailView.setError(getString(R.string.error_field_required));
            focusView = mEmailView;
            cancel = true;
        }
        else if (!mEmail.contains("@")) {
            mEmailView.setError(getString(R.string.error_invalid_email));
            focusView = mEmailView;
            cancel = true;
        }

        if (cancel) {
            // There was an error; don't attempt login and focus the first
            // form field with an error.
            focusView.requestFocus();
        }
        else {
            // Show a progress spinner, and kick off a background task to
            // perform the user login attempt.
            mLoginStatusMessageView.setText(R.string.login_progress_signing_in);
            showProgress(true);
            mAuthTask = new UserLoginTask();
            mAuthTask.execute((Void) null);
        }
    }

    /**
     * Shows the progress UI and hides the login form.
     */
    @TargetApi(Build.VERSION_CODES.HONEYCOMB_MR2)
    private void showProgress(final boolean show) {
        // On Honeycomb MR2 we have the ViewPropertyAnimator APIs, which allow
        // for very easy animations. If available, use these APIs to fade-in
        // the progress spinner.
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB_MR2) {
            int shortAnimTime = getResources().getInteger(android.R.integer.config_shortAnimTime);

            mLoginStatusView.setVisibility(View.VISIBLE);
            mLoginStatusView.animate().setDuration(shortAnimTime).alpha(show ? 1 : 0).setListener(new AnimatorListenerAdapter() {
                @Override
                public void onAnimationEnd(Animator animation) {
                    mLoginStatusView.setVisibility(show ? View.VISIBLE : View.GONE);
                }
            });

            mLoginFormView.setVisibility(View.VISIBLE);
            mLoginFormView.animate().setDuration(shortAnimTime).alpha(show ? 0 : 1).setListener(new AnimatorListenerAdapter() {
                @Override
                public void onAnimationEnd(Animator animation) {
                    mLoginFormView.setVisibility(show ? View.GONE : View.VISIBLE);
                }
            });
        }
        else {
            // The ViewPropertyAnimator APIs are not available, so simply show
            // and hide the relevant UI components.
            mLoginStatusView.setVisibility(show ? View.VISIBLE : View.GONE);
            mLoginFormView.setVisibility(show ? View.GONE : View.VISIBLE);
        }
    }

    /**
     * Represents an asynchronous login/registration task used to authenticate
     * the user.
     */
    public class UserLoginTask extends AsyncTask<Void, Void, Boolean> {
        @Override
        protected Boolean doInBackground(Void... params) {
            // TODO: attempt authentication against a network service.

            try {
                // Simulate network access.
                Thread.sleep(2000);
            }
            catch (InterruptedException e) {
                return false;
            }

            for (String credential : DUMMY_CREDENTIALS) {
                String[] pieces = credential.split(":");
                if (pieces[0].equals(mEmail)) {
                    // Account exists, return true if the password matches.
                    return pieces[1].equals(mPassword);
                }
            }

            // TODO: register the new account here.
            return true;
        }

        @Override
        protected void onPostExecute(final Boolean success) {
            mAuthTask = null;
            showProgress(false);

            if (success) {
                finish();
            }
            else {
                mPasswordView.setError(getString(R.string.error_incorrect_password));
                mPasswordView.requestFocus();
            }
        }

        @Override
        protected void onCancelled() {
            mAuthTask = null;
            showProgress(false);
        }
    }
}

如果它取决于特定的情况,那么使用HttpClient从互联网加载ListView项(文本+位图),我应该如何实现我的AsyncTask?

siv3szwd

siv3szwd1#

实现AsyncTask并没有一种“正确”的方法,但我还是要说几句:
该类用于在Activity的上下文中执行“轻”工作。这就是为什么它在UI线程中运行onPreExecuteonProgressUpdateonPostExecute方法,以便它们可以快速访问字段和更新GUI。任何可能需要较长时间才能完成且不打算更新特定Activity的任务都应移动到Service。
这些方法主要用于更新GUI。由于GUI与Activity示例相关(字段可能被声明为私有成员变量),因此将AsyncTask实现为非静态嵌套类更方便。在我看来,这也是最自然的方式。
如果任务要在其他活动中重用,我认为应该允许它拥有自己的类。老实说,我不喜欢静态嵌套类,尤其是在视图中。如果它是一个类,这意味着它在概念上不同于活动。如果它是静态的,这意味着它与活动的具体示例无关。但是由于它们是嵌套的,这些类在视觉上位于父类内部,这使得它更难阅读,并且在项目包浏览器中可能会被忽略,因为它只显示文件。尽管比内部类耦合性更低,但这并不是真正有用的:如果类发生了变化,你必须将整个父文件合并/提交到版本控制中。如果你要重用它,那么你必须在任何地方都以Parent.Nested的身份访问它。因此,为了不将其他活动耦合到Parent类,你可能需要重构它并将嵌套的类提取到它自己的文件中。
所以对我来说,问题是 * 内部类与顶级类 *。

zpf6vheq

zpf6vheq2#

一般来说,我会推荐静态实现(尽管两者都可以接受)。
Google的方法需要的代码较少,但是你的asynctask会和你的activity紧密耦合(这意味着不容易重用),但是有时候这种方法可读性更强。
使用CommonsGuy方法,将需要更多的努力(和更多的代码)来解耦活动和asynctask,但最终您将拥有更模块化,更可重用的代码。

ars1skjm

ars1skjm3#

链接的文章已经说了
不过,这确实强调了你希望AsyncTask的doInBackground()与Activity完全解耦。如果你只在主应用程序线程上接触Activity,AsyncTask可以在方向更改后完好无损地生存下来。
不要从AsyncTask触摸Activity(例如其成员),这与Static Nested Classes一致

静态嵌套类

与类方法和变量一样,静态嵌套类与其外部类相关联。并且像静态类方法一样,静态嵌套类不能直接引用其封闭类中定义的示例变量或方法-它只能通过对象引用来使用它们。
尽管如此,来自Android,AsyncTask reference和Using AsyncTask的示例仍然使用非静态嵌套类。
根据这个Static nested class in Java, why?,我将首先使用 static 内部类,如果确实有必要,只使用非静态版本。

fquxozlt

fquxozlt4#

我发现,当你需要通过在onProgressUpdate中调用runOnUiThread来频繁更新UI时,非静态嵌套Asynctask UI更新速度更快。例如,当你必须向TextView追加行时。

non-static:
    @Override
    protected void onProgressUpdate(String... values) {
        runOnUiThread(() -> {
            TextView tv_results = findViewById(R.id.tv_results);
            tv_results.append(values[0] + "\n");
        });
    }

它比为静态AsyncTask实现侦听器快1000倍。我可能错了,但这是我的经验。

static:
        @Override
        protected void onProgressUpdate(String... values) {
            OnTaskStringUpdatedListener.OnTaskStringUpdated(task, values[0]);
        }

相关问题