xcode 如何在Objective-C中安全地将`_Nullable`转换为`_Nonnull`?

ffscu2ro  于 2023-06-07  发布在  其他
关注(0)|答案(3)|浏览(380)

当使用-Wnullable-to-nonnull-conversion编译时,我们会得到一个正确的警告,代码如下:

NSString * _Nullable maybeFoo = @"foo";
^(NSString * _Nonnull bar) {  
}(maybeFoo);

Tests.m:32:7: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
    }(maybeFoo);
      ^
1 error generated.

如何安全地将fooNSString * _Nullable转换为NSString * _Nonnull

目前为止最好的解决方案

我最好的办法就是这个宏:

#define ForceUnwrap(type, nullableExpression) ^type _Nonnull () { \
  type _Nullable maybeValue___ = nullableExpression; \
  if (maybeValue___) { \
    return (type _Nonnull) maybeValue___; \
  } else { \
    NSLog(@"Attempted to force unwrap a null: " #nullableExpression); \
    abort(); \
  } \
}()

它的用法如下:

NSString * _Nullable maybeFoo = @"foo";
if (maybeFoo) {
    NSString * _Nonnull foo = ForceUnwrap(NSString *, maybeFoo);
    ^(NSString * _Nonnull bar) {
    }(foo);
}

如果赋值给错误类型的变量,则会产生错误:

NSString * _Nullable maybeFoo = @"foo";
if (maybeFoo) {
    NSNumber * _Nonnull foo = ForceUnwrap(NSString *, maybeFoo);
    ^(NSNumber * _Nonnull bar) {
    }(foo);
}

Tests.m:40:29: error: incompatible pointer types initializing 'NSNumber * _Nonnull' with an expression of type 'NSString * _Nonnull' [-Werror,-Wincompatible-pointer-types]
        NSNumber * _Nonnull foo = ForceUnwrap(NSString *, maybeFoo);
                            ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

如果强制转换为错误的类型,则会产生错误:

NSString * _Nullable maybeFoo = @"foo";
if (maybeFoo) {
    NSNumber * _Nonnull foo = ForceUnwrap(NSNumber *, maybeFoo);
    ^(NSNumber * _Nonnull bar) {
    }(foo);
}

Tests.m:40:35: error: incompatible pointer types initializing 'NSNumber * _Nullable' with an expression of type 'NSString * _Nullable' [-Werror,-Wincompatible-pointer-types]
        NSNumber * _Nonnull foo = ForceUnwrap(NSNumber *, maybeFoo);
                                  ^                       ~~~~~~~~
Tests.m:27:16: note: expanded from macro 'ForceUnwrap'
type _Nullable maybeValue___ = nullableExpression; \
               ^               ~~~~~~~~~~~~~~~~~~
1 error generated.

不幸的是,如果你需要转换为一个带有多个参数的泛型类型,你必须求助于preprocessorhacks

NSDictionary<NSString *, NSString *> * _Nullable maybeFoo = 
[NSDictionary<NSString *, NSString *> new];
if (maybeFoo) {
  NSDictionary<NSString *, NSString *> * _Nonnull foo =
#define COMMA ,
  ForceUnwrap(NSDictionary<NSString * COMMMA NSString *>, maybeFoo);
#undef COMMA
  ^(NSDictionary<NSString *, NSString *> * _Nonnull bar) {
  }(foo);
}

我试过的都没用

maybeFoo直接分配给NSString * _Nonnull不起作用。它会产生与之前相同的错误:

NSString * _Nullable maybeFoo = @"foo";
if (maybeFoo) {
  NSString * _Nonnull foo = maybeFoo;
  ^(NSString * _Nonnull bar) {  
  }(foo);
}

Tests.m:30:35: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
        NSString * _Nonnull foo = maybeFoo;
                                  ^
1 error generated.

而将maybeFoo转换为NSString * _Nonnull并不安全,因为如果maybeFoo的类型发生了变化,编译器不会中断:

NSNumber * _Nullable maybeFoo = @"foo";
if (maybeFoo) {
  NSString * _Nonnull foo = (NSString * _Nonnull) maybeFoo;
  ^(NSString * _Nonnull bar) {  
  }(foo);
}
// no errors!

我还尝试在强制转换时使用__typeof__,但__typeof__带有空性说明符,因此当您尝试强制转换为__typeof__(maybeFoo) _Nonnull时,您会遇到空性冲突:

NSString * _Nullable maybeFoo = @"foo";
if (maybeFoo) {
    NSString * _Nonnull foo = (__typeof__(maybeFoo) _Nonnull) maybeFoo;
    ^(NSString * _Nonnull bar) {
    }(foo);
}

Tests.m:30:57: error: nullability specifier '_Nonnull' conflicts with existing specifier '_Nullable'
        NSString * _Nonnull foo = (__typeof__(maybeFoo) _Nonnull) maybeFoo;
                                                        ^
Tests.m:30:35: error: implicit conversion from nullable pointer 'NSString * _Nullable' to non-nullable pointer type 'NSString * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
        NSString * _Nonnull foo = (__typeof__(maybeFoo) _Nonnull) maybeFoo;
                                  ^
2 errors generated.

所有内容都使用深度静态分析器运行,并使用Xcode 8.2.1编译,并带有以下标志:

-Wnon-modular-include-in-framework-module 
-Werror=non-modular-include-in-framework-module
-Wno-trigraphs
-Werror
-Wno-missing-field-initializers
-Wno-missing-prototypes
-Wunreachable-code
-Wno-implicit-atomic-properties
-Wno-arc-repeated-use-of-weak
-Wduplicate-method-match
-Wno-missing-braces
-Wparentheses
-Wswitch
-Wunused-function
-Wno-unused-label
-Wno-unused-parameter
-Wunused-variable
-Wunused-value
-Wempty-body
-Wuninitialized
-Wno-unknown-pragmas
-Wno-shadow
-Wno-four-char-constants
-Wno-conversion
-Wconstant-conversion
-Wint-conversion
-Wbool-conversion
-Wenum-conversion
-Wshorten-64-to-32
-Wpointer-sign
-Wno-newline-eof
-Wno-selector
-Wno-strict-selector-match
-Wundeclared-selector
-Wno-deprecated-implementations
-Wno-sign-conversion
-Wno-infinite-recursion
-Weverything
-Wno-auto-import
-Wno-objc-missing-property-synthesis
-Wno-cstring-format-directive
-Wno-direct-ivar-access
-Wno-double-promotion
wb1gzix0

wb1gzix01#

到目前为止,我发现的最好的是泛型的技巧。
实际上,您定义了一个使用泛型的接口,并有一个返回泛型类型nonnull的方法。然后在宏中使用typeof,但在泛型类型上,这会给您正确的类型。
请注意,泛型类从不示例化,它只是用来获取正确的类型。

@interface RBBBox<__covariant Type>

- (nonnull Type)asNonNull;

@end

#define RBBNotNil(V) \
    ({ \
        NSCAssert(V, @"Expected '%@' not to be nil.", @#V); \
        RBBBox<__typeof(V)> *type; \
        (__typeof(type.asNonNull))V; \
    })

不过,这不是我的主意。来源:https://gist.github.com/robb/d55b72d62d32deaee5fa

yhived7q

yhived7q2#

我使用这个宏:

#define assumeNotNull(_value)         \
({                                    \
    if (!_value) abort();             \
    __auto_type const _temp = _value; \
    _temp;                            \
})

当然,只有在代码中进行适当的测试之后:

if (parameters) {
    [obj processParameters:assumeNotNull(parameters)];
}

忽略宏,编译器会告诉我参数可能是NULL,但processParameters需要一个非NULL参数。在我的例子中,这甚至被配置为一个错误,而不仅仅是一个警告。
省略if检查,代码将编译,但如果我输入NULL,应用程序将当场崩溃。所以你应该只在测试后使用宏,或者如果你绝对确定这个值不可能是NULL,并且你非常确定,你愿意把你的应用程序稳定性押在上面。
如果有疑问,请始终进行测试并记住,如果测试显然是不必要的(例如如果这个条件之前已经被测试过了,如果这个值是NULL,那么这个代码将永远不会被达到),编译器将在优化阶段检测到这个情况,并为你删除这个测试。不必要的测试几乎从来都不是性能问题,尤其是对于如此廉价的测试。

更新

从Xcode 14.3(LLVM 15)开始,clang不再理解if语句确保_value不是NULL(毕竟abort()是一个不返回函数),而是仍然抛出错误。参见issue 63018
作为解决方法,您可以使用此宏:

#define assumeNotNull(_value)         \
({                                    \
    if (!_value) abort();             \
    __auto_type const _temp = _value; \
    (typeof(*_temp) *_Nonnull)_temp;  \
})

在大多数情况下可以正常工作,但不适用于块,因为您无法取消对块的引用。我仍然希望找到一个更好的解决办法。
这种变化的原因可能是一个旧的雷达:http://www.openradar.me/36877120
同样在两个月前,有人已经在苹果开发者论坛上抱怨了这个变化:https://developer.apple.com/forums/thread/726000

7qhs6swi

7qhs6swi3#

Michael Ochs' answer基本上是正确的,但我后来遇到了一些静态分析器警告,因为其中缺乏硬_Nonnull保证。简而言之,如果我们收到一个nil,我们必须abort,否则当我们这样做时:

@interface Foo : NSObject
+ (NSString * _Nullable)bar;
@end

int main(int argc, char * argv[]) {
  NSString * _Nonnull bar = RBBNotNil([Foo bar]);
}

Release配置中(在我的例子中,当存档时),静态分析器将抱怨您试图将_Nullable值分配给_Nonnull左值。我收到了这样的警告:

nil assigned to a pointer which is expected to have non-null value

这是我的更新版本:

// We purposefully don't have a matching @implementation.
// We don't want +asNonnull to ever actually be called
// because that will add a lot of overhead to every RBBNotNil
// and we want RBBNotNil to be very cheap.
// If there is no @implementation, then if the +asNonnull is
// actually called, we'll get a linker error complaining about
// the lack of @implementation.
@interface RBBBox <__covariant Type>

// This as a class method so you don't need to
// declare an unused lvalue just for a __typeof
+ (Type _Nonnull)asNonnull;

@end

/*!
 * @define RBBNotNil(V)
 * Converts an Objective-C object expression from _Nullable to _Nonnull. 
 * Crashes if it receives a nil! We must crash or else we'll receive
 * static analyzer warnings when archiving. I think in Release mode,
 * the compiler ignores the _Nonnull cast.
 * @param V a _Nullable Objective-C object expression
 */
#define RBBNotNil(V) \
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wgnu-statement-expression\"") \
({ \
__typeof__(V) __nullableV = V; \
NSCAssert(__nullableV, @"Expected '%@' not to be nil.", @#V); \
if (!__nullableV) { \
    abort(); \
} \
(__typeof([RBBNotNil<__typeof(V)> asNonnull]))__nullableV; \
}) \
_Pragma("clang diagnostic pop")

相关问题