element-plus [Style] [dialog] [style] [dialog] el-dialog has a style issue that affects upgrades 【el-dialog 存在一个引升级影响的样式问题】

piv4azn7  于 5个月前  发布在  其他
关注(0)|答案(1)|浏览(62)

Bug Type: Style

Environment

  • Vue Version: 3.3.4
  • Element Plus Version: 2.6.1
  • Browser / OS: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36
  • Build Tool: Vite

Reproduction

  • el-dialog

Element Plus Playground

Steps to reproduce

【结果】从原来有的V2.4.3 升级到最新的V2.6.1。dialog组件的样式产生严重变化,原有el-dialog__body的padding,全部挪至了el-dialog层级
【链接】最小复现链接内,element-plus由V2.4.3切换到V2.6.1即可。
【原因】经过筛查,从V2.5.3升级到V2.5.4的版本发布时产生次问题,问题提交的PR地址, https://github.com/element-plus/element-plus/pull/15643/files,提交的拖到内容最后,发现删除了body处的padding,内容如下

@include e(body) {

  • padding: calc(#{getCssVar('dialog-padding-primary')} + 10px)
  • getCssVar('dialog-padding-primary');
    color: getCssVar('text-color', 'regular');
    font-size: getCssVar('dialog-content-font-size');
    }

==============================
[Result] Upgrade from the original V2.4.3 to the latest V2.6.1. The style of the dialog component has been severely changed, and the padding of the original el-dialog__body has been moved to the el-dialog level
[Link] Within the minimum repeat link, element-plus can be switched from V2.4.3 to V2.6.1.
[because] after screening, from V2.5.3 upgrade to V2.5.4 generated when the release time of the problem, problem submit PR address, https://github.com/element-plus/element-plus/pull/15643/files , the content of the submitted to, We found that the padding in the body was removed, as follows

@include e(body) {

  • padding: calc(#{getCssVar('dialog-padding-primary')} + 10px)
  • getCssVar('dialog-padding-primary');
    color: getCssVar('text-color', 'regular');
    font-size: getCssVar('dialog-content-font-size');
    }

What is Expected?

升级版本不应导致需要对原有样式进行审查,影响以后业务。
An upgraded version should not result in a review of the original style, affecting future business.

What is actually happening?

升级之后影响了样式,需要重新更改
After upgrading, the style has been affected and needs to be changed again

Additional comments

此次更改是否是因为技术需要或者样式结构调整导致。请避免因升级产生要对样式进行重新处理的问题。相关api修改及废弃是有相关公告的,但是样式更改希望也能有相关,翻阅历史版本更新记录未发现此次修改的说明,尤其是V2.5.3升级到V2.5.4的更新文档
Whether this change is due to technical requirements or style structure adjustments. Avoid the problem of having to reprocess the style as a result of the upgrade. There are relevant announcements about api modification and abandonment, but the style change is also expected to be relevant, and no description of the modification can be found when browsing the historical version update record, especially the update document of V2.5.3 upgrade to V2.5.4

相关问题