ant-design TimePicker Popup use12Hours AM and PM labels are not covered by internationalization

wlzqhblo  于 5个月前  发布在  其他
关注(0)|答案(6)|浏览(67)

Steps to reproduce

Open TimePicker Popup to change value.

when the Timepicker or Datetimepicker is clicked , "am" and "pm" fields in the popup sholuld be displayed according to my locale,
for example: When I set my locale as "tr", it should be "öö" and "ös" instead of "am" and "pm"

Reference #31520 , #35655

What is expected?

AM and PM labels must be Turkish characters

What is actually happening?

AM and PM labels are not changing by language
| Environment | Info |
| ------------ | ------------ |
| antd | 5.16.0 |
| React | 18.2.0 |
| System | 22H2 Windows11 |
| Browser | 123.0.6312.86 Google Chrome |

tgabmvqs

tgabmvqs1#

Please make your CodeSandbox public

6tr1vspr

6tr1vspr2#

Hello @ozkanaydin01. Please provide a online reproduction by forking codesandbox of antd@5.x or antd@4.x , or provide a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @ozkanaydin01,我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击这里创建一个 antd@5.xantd@4.x 的 codesandbox,或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。
什么是最小化重现,为什么这是必需的?

yjghlzjz

yjghlzjz3#

I changed the project to public and the antd vesion is 5.x now

7eumitmz

7eumitmz4#

any updates on this? seems still happen in 5.19.1, only zhCN is localized in the Picker panel, all other languages are still AM/PM. @afc163

vm0i2vca

vm0i2vca5#

We should add https://github.com/react-component/picker/blob/04b3232a5acb48fe5a990c2d5cc75846c0f7fbcc/src/locale/zh_CN.ts#L9 to https://github.com/react-component/picker/blob/master/src/locale/tr_TR.ts

wxclj1h5

wxclj1h56#

Hello @ozkanaydin01. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @ozkanaydin01,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的 预设模板 ,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

相关问题